Updates from March, 2013 Toggle Comment Threads | Keyboard Shortcuts

  • Will Norris 2:59 pm on March 11, 2013 Permalink | Log in to leave a Comment  

    @danroundhill: I apologize for not asking you about this before I submitted r958, but I wanted to get your thoughts on moving activities (and related UI code) under a ‘ui’ package. My thinking was to put general purpose and base classes directly in the ui package, and then have sub packages under there for the main logical parts of the app… accounts, posts, prefs, reader, etc. r958 and r959 demonstrate the beginning of that.

    I know that a lot of these activities have more than just UI code in them, but that’s actually kind of the point. I’d like to eventually pull a lot of that network and business logic out of the activities so that it is more reusable (similar to what was very briefly started in #363).

    Since this involves moving a lot of code around, I wanted to double check with you before heading down this road.

     

    • Dan 8:58 am on March 12, 2013 Permalink | Log in to Reply

      No worries, I reviewed the commit and it all looks good. I tried to get better organization of the code going in 2.0 by adding the util and model packages, but even after that there’s still quite a bit left in the root.

      I also feel like we should rename some of the Classes so that you can better understand what it does by reading just the name. For example, we could put the type after the name so ‘Posts’ would become ‘PostsActivity’.

      • Will Norris 9:00 am on March 12, 2013 Permalink | Log in to Reply

        yep, completely agree about adding “Activity” suffix to class name where appropriate. I’ve done that on the new classes I created, and planned to do the same when I migrate others over to the new package.

        • Dan 10:17 am on March 12, 2013 Permalink | Log in to Reply

          And probably the fragments should be renamed to match up as well, e.g. ‘PostsListFragment’

      • Eric 11:39 am on March 12, 2013 Permalink | Log in to Reply

        +1 to this. I remember some of the comment class naming was a bit confusing.

  • Will Norris 8:04 pm on March 6, 2013 Permalink | Log in to leave a Comment  

    this afternoon, @danroundhill and I chatted briefly about a coding style guide for wp-android, and agreed to just use (or at least start with) the basic android style guide. For future code, I’ve gone ahead and added a project-specific java formatter based on that guide. For existing code, much of the changes can be pretty easily scripted. The one real downside is that doing mass changes to code like this tends to make tools like `svn blame` somewhat useless until other significant changes are made to the file. I’m personally okay with that (I figure the sooner the better), but wanted to check with others before I do any large commits of this type. Also, any changes people are working that haven’t yet checked in yet may be slightly disrupted; you’ll have to merge in these changes, since most every java file will be touched.

     

    • Dan 10:07 am on March 7, 2013 Permalink | Log in to Reply

      You can pretty much just blame me for most of the nasty code :)

      • Will Norris 10:11 am on March 7, 2013 Permalink | Log in to Reply

        actually `svn blame` is really useful for seeing when a particular line of code was last touched. I’ve been using it a lot as I read through code. It won’t be entirely useless though… you can always run blame on a previous version of the file.

        So does that mean you’re okay with going ahead with a mass style update?

  • Will Norris 4:38 pm on February 15, 2013 Permalink | Log in to leave a Comment  

    I asked about it in chat earlier this week, but @ievolver wasn’t entirely sure… can we get rid of the GPL screen that is displayed on first launch? It’s meaningless to have an end user agree to the GPL, since it doesn’t apply to them at all (it’s not a EULA)… it applies to developers. And it’s not the best first experience for users to see a full screen of legal jargon.

    Besides, I think Android is the only app that does this (well, at least iOS doesn’t do it).

    @danroundhill: any objections?

     

    • Dan 4:44 pm on February 15, 2013 Permalink | Log in to Reply

      No objections, I think I added that way back based on Google’s guidelines to have some sort of EULA in there. But yeah it doesn’t really work to use the GPL for that.

  • Koke 2:17 am on February 12, 2013 Permalink | Log in to leave a Comment
    Tags: previews   

    @danroundhill I’ve pushed what I got so far for better previews to https://github.com/koke/wordpress-android/compare/previews

    Can you take a look at it and commit it if it looks good?

     

  • Will Norris 12:00 pm on February 7, 2013 Permalink | Log in to leave a Comment
    Tags: maven   

    Migrating to Maven

    I’ve just pushed a git branch that includes the initial set of changes to migrate to maven for building the app. You can see the pull request on github here. I’d love to have someone else go through the process of trying this out themselves to make sure I didn’t overlook anything before I submit this. You can just checkout the ‘maven’ branch on my git repository, and follow the readme file.

     

    • Dan 7:05 pm on February 7, 2013 Permalink | Log in to Reply

      I will try this out soon!

    • Chris Truman 3:50 pm on February 11, 2013 Permalink | Log in to Reply

      It worked successfully for me. Pulled from the maven branch and ran the readme commands and it deployed successfully.

    • Will Norris 3:56 pm on February 11, 2013 Permalink | Log in to Reply

      awesome, thanks Chris!

    • Dan 9:26 am on February 12, 2013 Permalink | Log in to Reply

      Worked great when building from the command line, but when i added the project to eclipse I had to manually add the ActionBarSherlock library to the project properties to get it compiling.

      • Koke 4:47 am on February 13, 2013 Permalink | Log in to Reply

        I’m not too familiar with android build processes, but would it make sense to include ActionBarSherlock inside WPAndroid repo?

    • Will Norris 10:01 am on February 12, 2013 Permalink | Log in to Reply

      *sigh* yeah, you’re right… I forgot to test in eclipse without my Sherlock project open. I’ll keep digging to see if there is a way.

      It doesn’t help us at all right now, but one small consolation is that it seems the Android team is working on a new version of ADT that will handle dependency management, project building, etc using Gradle.

    • Koke 4:45 am on February 13, 2013 Permalink | Log in to Reply

      @danroundhill ping me when this is merged.
      Right now the build server is failing to build because of missing dependencies to ActionBarSherlock. IIRC the migration to maven was (mostly) to help with this, so I guess we’d need to change how the app is built on Jenkings

    • Will Norris 9:21 am on February 13, 2013 Permalink | Log in to Reply

      I’m going to update the readme to include instructions for setting up ActionBarSherlock with eclipse, then submit, since maven seems to be working well for building from the command line.

    • Will Norris 9:36 am on February 14, 2013 Permalink | Log in to Reply

      just an update on this, that I revert the change to add maven support. It turns out that there are more problems than I realized with using eclipse + maven + apklib projects. All the gory details can be found here and here. There’s an open patch to the ADT, but until that is fixed there’s no good workaround.

      For now, I’m gong to update the readme to include correct command line build instructions (@koke, I guess you’ll need to update the build server again), while exploring other possible options.

  • Will Norris 8:18 am on January 22, 2013 Permalink | Log in to leave a Comment  

    @danroundhill: during last week’s dev chat you asked about sliding menus. Not sure if you have done much research into, but this project just came across my desk today (at least one team at Google is planning on using it) that might be worth looking into: https://github.com/jfeinstein10/SlidingMenu It has instructions for working with ActionBarSherlock, which is definitely promising.

    Kinda makes me want to do a navigation UI sprint that adds in a real action bar and this slideing menu. Maybe not a full UI overhaul, as I don’t think that’s really necessary… but just the two of these would be great additions. You mentioned you already had a patch for adding in Sherlock. How far along is that?

     

    • Dan 8:37 am on January 22, 2013 Permalink | Log in to Reply

      Yes, there’s actually a few of us now that feel like a sliding menu + Action Bar would be an awesome upgrade for the app. I think the Action Bar version I was working on is 70% there. I can get it wrapped up and committed (somewhere) this week.

      Sounds like this is a good feature change for version 2.3 :) Ping @kokejb, I know you had some thoughts on this as well.

      • Koke 10:15 am on January 22, 2013 Permalink | Log in to Reply

        Yeah, we discussed in the past trying to unify the UI across all the apps, but staying true to the platform. The funny thing is that making the android app more modern by using action bars + sliding menu, we’d also be closer to the iOS UI.

        My thoughts for it were (and most of it applies to other platforms as well):

        • Have reader and blogs in a sliding menu.
        • Switch between posts/pages/comments/stats/… in a spinner

        But then… how often do you go to edit a 2 months old post? or look at comments that you already read/moderated/replied?

        Why not merge the reader with everything else? So here’s another thought:

        • “Read” becomes your stream/home/news feed/… The current reader starts including your own posts (from any blog)
        • There’s a new reader section: I’d say “My posts” but I think it’s about time we have “Profile”/”Me”/”John Smith”. A good place to add the functionality to change your gravatar btw.
        • Notifications are the main way to keep up with new stuff: new comments, stats highlights, likes, new posts in your blogs,… whatever is new that you should know and don’t.
        • Stats: combined stats of all your blogs, see what’s popular, if you got unusual traffic coming from a mention, swipe view to view individual blog stats,… It might require a separate section since stats are very popular, or just be included in your profile
        • Search anywhere: partly to balance the new more combined UI, and partly to fix a current problem, you should be able to search/filter anywhere in the app where there’s more than a few data items. Say in one month I want to reference this comment, but I can’t remember when or where I post it… I tap the search box, type “Koke android UI” and boom!, it’s there

        Pages are more complicated, since many users will only have an About page (and maybe a few more), but in the case of WP as a CMS, pages could be one of the most useful things in the app.
        So for pages, and other more specific use cases, we can keep the per-blog posts/pages/comments/stats navigation “hidden” in the sliding menu

        Now, most of this comment is just raw ideas, and not trivial to implement (specially thinking of combined stats and search), but we can start taking small steps until we arrive there

        Maybe we can talk about it a bit more in tomorrow’s dev chat?

        • Koke 10:20 am on January 22, 2013 Permalink | Log in to Reply

          Also, both in the new stream view or the current post list, I’d drop the “list style” and start showing more of the post content: excerpt, image thumbnail or feature image if there is one

        • Isaac Keyet 11:36 am on January 22, 2013 Permalink | Log in to Reply

          Small wins are the best wins. We may be headed in this direction but we nothing is certain just yet.

          If we could start by adding the native appbar and a sliding menu (spinner?) as a first step I think that’d be a huge win and would teach us a lot about what’s to come.

          • Will Norris 1:45 pm on January 22, 2013 Permalink | Log in to Reply

            agreed, I think just starting with a simplified sliding menu that covers the existing navigation options (blog selector and the current dashboard) would be fine. Once the basic framework is in place, it’s much easier to then experiment with ways of organizing the menu, putting notifications in the menu a la Google+, etc.

    • Dan 1:58 pm on January 22, 2013 Permalink | Log in to Reply

      Slightly related :) @ievolver, there’s a style generator for the action bar/holo. You should play around with it sometime:

      http://jgilfelt.github.com/android-actionbarstylegenerator/

      Personally I like how it looks with the light theme with dark action bar, and use a dark WP blue for the action bar background with a white WP logo.

  • Danilo 4:38 am on January 13, 2013 Permalink | Log in to leave a Comment  

    Hey @danroundhill, I need a new app icon that is a 114 x 114 pixel square. Do you have the PSD file of the app icon somewhere in your folders? (It will be used for the BB10 porting).

     

  • Dan 1:46 am on September 22, 2011 Permalink | Log in to leave a Comment
    Tags: 2.0   

    2.0 Features 

    Here’s what’s on the TODO list for 2.0!

    dashboard

    Dashboard UI
    The current blog list home will be replaced with a dashboard UI that will make it easy to access everything you’d want to do in the app. The dashboard view will scale to support tiny screens all the way up to tablets.

    Action Bar
    There will be an Action Bar at the top of every view in the app, so that you can switch blogs easily wherever you happen to be in the app. Tapping the top-right button will overlay the dashboard buttons wherever you are in the app for quick access to common actions.

    Formatting toolbar above keyboard
    Instead of having the formatting buttons in the post editor in the edit view, we’ll move the buttons to reside above the virtual keyboard. This way will make it much easier to add rich formatting to the post. Basically like this.

    Post Formats
    The app will display the post formats available for the theme the blog is using and allow the user to apply the post format to the post in the edit view.

    Stats Widget
    A contributor has been working on a stats widget that will integrate nicely with the app.

    Honeycomb Support
    The app will have upgraded layouts to better support the user experience on honeycomb tablets.

    The Dashboard and Action Bar are currently under development, but the other features are available. If you want to have a crack at them, check out trunk from SVN and let us know on #wordpress-mobile in freenode how it’s going!

     

  • Dan 3:37 pm on February 18, 2011 Permalink | Log in to leave a Comment  

    Devs – Do you feel like what’s in trunk is ready for a 1.4.0 beta?

     

    • Christof 2:14 pm on February 19, 2011 Permalink | Log in to Reply

      There are 2 patches waiting to be added to the repository (#42, #126).

      Then there are 3 (#85, #101, #121) issues where I wanted to do a patch for, for 1.4.0.

      What if you do a beta on Tuesday? So I can work on more patches until Tuesday.

      (I will move pull to refresh to the next release, I have no idea (so far) how Twitter got it to work with Android versions prior to 2.2)

      In general, is there a freeze on implementing new features when you release a beta (so only fixing bugs from the beta), or can other tickets go into 1.4.0 even though the beta has already been released?

      • Dan 5:24 am on February 21, 2011 Permalink | Log in to Reply

        Cool, I just committed the patch for #126. Not sure if #42 should be in there, seems weird to have two ways to accomplish the same thing in one view. Thoughts?

        We can wait another week if you’d like to get those other patches in there. It’s best to feature freeze the betas so no surprise bugs come up from last minute features that were added.

        • Christof 5:32 am on February 21, 2011 Permalink | Log in to Reply

          Okay, thought that the tickets in Trac should get implemented. But if it doesn’t make sense just leave it out :) (I closed the ticket as ‘wontfix’)

          I will implement these last 3 todos tonight, so releasing a beta tomorrow should be alright.

          Question is if you want to include #122 in this beta? Seeing #124 fixed would also be nice for 1.4.0.

        • Christof 12:58 pm on February 21, 2011 Permalink | Log in to Reply

          There’s a patch available for #101.

          And I moved the other two tickets to the next release, since I need to change the XMLRPC request to metaWeblog.getRecentPosts for #121 (no post status in blogger.getRecentPosts).
          And I need to find out if a post/page has not been closed for comments for #85.
          And both changes are a bit too drastic just before the beta release. I will implement those two for the next release.

          So everything on my side done for 1.4.0 beta build.

          • Dan 1:57 am on February 24, 2011 Permalink | Log in to Reply

            Ok cool, thanks! I will take a look at the others and get the beta out there. I’m wondering if we should squeeze in a few honeycomb tweaks as well… feature creep!

    • quicoto 4:12 pm on February 19, 2011 Permalink | Log in to Reply

      Christof, yeah I’m using the Twitter App in my HTC Hero 2.1 and hell, the scroll down refresh rocks :)

  • Ricard Torres 12:48 am on February 1, 2011 Permalink | Log in to leave a Comment
    Tags:   

    Was translating some strings and I got a question:

    Where does the app show the string “post_not_published” and “page_not_published”?

    Would be helpful to know the context to translate it.

    And about the QuickPress I think it also has some hardcoded strings: “Set shortcut name”

    Thanks.

     

← Older posts

c
compose new post
j
next post/next comment
k
previous post/previous comment
r
reply
e
edit
o
show/hide comments
t
go to top
l
go to login
h
show/hide help
shift + esc
cancel
Follow

Get every new post delivered to your Inbox.

Join 129 other followers